Fix sketch new default overwriting behavior
#1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
topic: code
umbynos
suggested changes
Nov 29, 2022
MatteoPologruto
force-pushed
the
sketch-new-fix
branch
from
0fc9fc6 to
3552cc5
Compare
Running "arduino-cli sketch new ." from a sketch directory overwrites an existing .ino sketch file, without asking for confirmation. This fix introduces a check to verify if the specified path already contains a .ino sketch file. If it does, an error is returned, otherwise a new sketch is created as usual.
…g .ino sketch file
Using the "--overwrite" flag, allows to create a new sketch overwriting an existing one.
MatteoPologruto
force-pushed
the
sketch-new-fix
branch
from
3552cc5 to
f962e64
Compare
umbynos
approved these changes
Nov 29, 2022
Comment on lines
+1773
to
+1774
| // be treated as read-only. This status is determined by the presence of a | ||
| // `.development` file in the library root directory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Code imperfection fix
What is the current behavior?
Running
arduino-cli sketch new .from a sketch directory overwrites an already existing.inosketch file by default.What is the new behavior?
It is no longer possible to overwrite an existing
.inosketch file in the above-mentioned way. Doing so, raises an error. It is, however, possible to force that behavior using the-f | --overwriteflag.Does this PR introduce a breaking change, and is titled accordingly?
No